Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2567913002: Rename ActiveDOMObject to SuspendableObject (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, shans, kenneth.christiansen, eae+blinkwatch, fs, eric.carlson_apple.com, mcasas+watch+mediarecorder_chromium.org, scheib+watch_chromium.org, apavlov+blink_chromium.org, kinuko+worker_chromium.org, Srirama, kinuko+watch, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, awdf+watch_chromium.org, toyoshim+midi_chromium.org, yhirano+watch_chromium.org, blink-reviews-css, tzik, jam, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, jkarlin+watch_chromium.org, wanming.lin, blink-reviews, darin-cc_chromium.org, falken+watch_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, mlamouri+watch-content_chromium.org, nessy, rjwright, Peter Beverloo, sof, nhiroki, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, timvolodine, darktears, jsbell+idb_chromium.org, vcarbune.chromium, jochen+watch_chromium.org, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, emircan+watch+mediarecorder_chromium.org, mlamouri+watch-test-runner_chromium.org, shalamov, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, serviceworker-reviews, gasubic, shimazu+worker_chromium.org, blink-reviews-html_chromium.org, ortuno+watch_chromium.org, kinuko+serviceworker, mcasas+watch+mediastream_chromium.org, cmumford, horo+watch_chromium.org, Mikhail, kinuko+fileapi, einbinder+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ActiveDOMObject to SuspendableObject This is a rename requested by https://codereview.chromium.org/2554813002/. Previously ActiveDOMObject was used to implement hasPendingActivity() of DOM wrappers, where the name "ActiveDOMObject" made sense. Then we moved hasPendingActivity() to ActiveScriptWrappable. Now ActiveDOMObject is a class that just provides resume/suspend. It would make more sense to rename it to SuspendableObject. BUG=610176 TBR=jam@chromium.org Committed: https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56 Cr-Commit-Position: refs/heads/master@{#437820}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -666 lines) Patch
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/leak_detector.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ActiveDOMObject.h View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp View 4 chunks +14 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 3 chunks +8 lines, -7 lines 1 comment Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/SuspendableObject.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/SuspendableObject.cpp View 1 chunk +14 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/SuspendableObjectTest.cpp View 3 chunks +19 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SuspendableTimer.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/SuspendableTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/streams/Stream.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/streams/Stream.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/AbstractWorker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/AbstractWorker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevices.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionStatus.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationAvailability.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognition.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseContext.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp View 3 chunks +4 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIPort.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/AsyncMethodRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/InstanceCounters.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLeakDetector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebLeakDetector.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
haraken
PTAL
4 years ago (2016-12-12 00:41:30 UTC) #2
dcheng
lgtm https://codereview.chromium.org/2567913002/diff/1/third_party/WebKit/Source/core/dom/ExecutionContext.h File third_party/WebKit/Source/core/dom/ExecutionContext.h (right): https://codereview.chromium.org/2567913002/diff/1/third_party/WebKit/Source/core/dom/ExecutionContext.h#newcode150 third_party/WebKit/Source/core/dom/ExecutionContext.h:150: // suspend Nit: merge comments on line 150 ...
4 years ago (2016-12-12 02:06:27 UTC) #3
haraken
> https://codereview.chromium.org/2567913002/diff/1/third_party/WebKit/Source/core/dom/ExecutionContext.h > File third_party/WebKit/Source/core/dom/ExecutionContext.h (right): > > https://codereview.chromium.org/2567913002/diff/1/third_party/WebKit/Source/core/dom/ExecutionContext.h#newcode150 > third_party/WebKit/Source/core/dom/ExecutionContext.h:150: // suspend > Nit: ...
4 years ago (2016-12-12 02:09:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567913002/1
4 years ago (2016-12-12 02:09:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 04:31:12 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 15:10:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56
Cr-Commit-Position: refs/heads/master@{#437820}

Powered by Google App Engine
This is Rietveld 408576698