third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp - Issue 2567913002: Rename ActiveDOMObject to SuspendableObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 2567913002: Rename ActiveDOMObject to SuspendableObject (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ExecutionContext.h ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h ('k') | third_party/WebKit/Source/modules/speech/SpeechRecognition.h » ('j') | third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

index 60c26b45a6df32840b18b3348887dd68b2149200..01f905d8da38163a961de74a9ec4fab323fc18ea 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

@@ -127,7 +127,7 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(

ExecutionContext* executionContext,

std::unique_ptr<WebServiceWorkerRegistration::Handle> handle)

: ActiveScriptWrappable(this),

- ActiveDOMObject(executionContext),

+ SuspendableObject(executionContext),

m_handle(std::move(handle)),

m_stopped(false) {

ASSERT(m_handle);

@@ -153,7 +153,7 @@ DEFINE_TRACE(ServiceWorkerRegistration) {

visitor->trace(m_active);

visitor->trace(m_navigationPreload);

EventTargetWithInlineData::trace(visitor);

- ActiveDOMObject::trace(visitor);

+ SuspendableObject::trace(visitor);

Supplementable<ServiceWorkerRegistration>::trace(visitor);

}