Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

Issue 2567913002: Rename ActiveDOMObject to SuspendableObject (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
index 2e98074037dd7754d80c0af9eed216dece7fe08a..1baedd00cecbfded6e09db978c68e5e8233108a0 100644
--- a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
+++ b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
@@ -86,10 +86,10 @@ void WebHelperPluginImpl::reallyDestroy(TimerBase*) {
void WebHelperPluginImpl::destroy() {
// Defer deletion so we don't do too much work when called via
- // stopActiveDOMObjects().
+ // stopSuspendableObjects().
// FIXME: It's not clear why we still need this. The original code held a
// Page and a WebFrame, and destroying it would cause JavaScript triggered by
- // frame detach to run, which isn't allowed inside stopActiveDOMObjects().
+ // frame detach to run, which isn't allowed inside stopSuspendableObjects().
// Removing this causes one Chrome test to fail with a timeout.
m_destructionTimer.startOneShot(0, BLINK_FROM_HERE);
}

Powered by Google App Engine
This is Rietveld 408576698