Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

Issue 2567913002: Rename ActiveDOMObject to SuspendableObject (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
index 0df407c988b5026f116bb084cd3a15b5b274aba4..489183609fb3db8c8f08d48ca3bf8d3c230edde6 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
@@ -10,8 +10,8 @@
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ToV8.h"
#include "core/CoreExport.h"
-#include "core/dom/ActiveDOMObject.h"
#include "core/dom/ExecutionContext.h"
+#include "core/dom/SuspendableObject.h"
#include "platform/ScriptForbiddenScope.h"
#include "platform/Timer.h"
#include "platform/heap/Handle.h"
@@ -24,13 +24,13 @@ namespace blink {
// functionalities.
// - A ScriptPromiseResolver retains a ScriptState. A caller
// can call resolve or reject from outside of a V8 context.
-// - This class is an ActiveDOMObject and keeps track of the associated
+// - This class is an SuspendableObject and keeps track of the associated
// ExecutionContext state. When the ExecutionContext is suspended,
// resolve or reject will be delayed. When it is stopped, resolve or reject
// will be ignored.
class CORE_EXPORT ScriptPromiseResolver
: public GarbageCollectedFinalized<ScriptPromiseResolver>,
- public ActiveDOMObject {
+ public SuspendableObject {
USING_GARBAGE_COLLECTED_MIXIN(ScriptPromiseResolver);
WTF_MAKE_NONCOPYABLE(ScriptPromiseResolver);
@@ -86,7 +86,7 @@ class CORE_EXPORT ScriptPromiseResolver
ScriptState* getScriptState() const { return m_scriptState.get(); }
- // ActiveDOMObject implementation.
+ // SuspendableObject implementation.
void suspend() override;
void resume() override;
void contextDestroyed() override { detach(); }
@@ -105,7 +105,7 @@ class CORE_EXPORT ScriptPromiseResolver
protected:
// You need to call suspendIfNeeded after the construction because
- // this is an ActiveDOMObject.
+ // this is an SuspendableObject.
explicit ScriptPromiseResolver(ScriptState*);
private:

Powered by Google App Engine
This is Rietveld 408576698