Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2567573002: DevTools: fix private field usage violation discovered after the compiler roll. (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
kozy, pfeldman1
CC:
chromium-reviews, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, je_julie, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, dmazzoni, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix private field usage violation discovered after the compiler roll. Committed: https://crrev.com/e6416ffa445788ca0613191ee72b5065b7780b79 Cr-Commit-Position: refs/heads/master@{#437612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -61 lines) Patch
M third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layers/LayerTreeModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/LayerTreeBase.js View 3 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 12 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pfeldman
4 years ago (2016-12-09 02:56:53 UTC) #2
kozy
lgtm
4 years ago (2016-12-09 03:06:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567573002/1
4 years ago (2016-12-09 19:27:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 19:51:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 14:37:01 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6416ffa445788ca0613191ee72b5065b7780b79
Cr-Commit-Position: refs/heads/master@{#437612}

Powered by Google App Engine
This is Rietveld 408576698