Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

Issue 2567573002: DevTools: fix private field usage violation discovered after the compiler roll. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
index 371a746d970400f069200a184d7ed907534c5c71..b85199e58899d237377a3c4cd066057058c6797c 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
@@ -270,7 +270,7 @@ Sources.CSSSourceFrame = class extends Sources.UISourceCodeFrame {
*/
_changeSwatchText(text) {
this._hadSwatchChange = true;
- this._textEditor.editRange(this._editedSwatchTextRange, text, '*swatch-text-changed');
+ this.textEditor.editRange(this._editedSwatchTextRange, text, '*swatch-text-changed');
this._editedSwatchTextRange.endColumn = this._editedSwatchTextRange.startColumn + text.length;
}
@@ -317,7 +317,7 @@ Sources.CSSSourceFrame = class extends Sources.UISourceCodeFrame {
* @return {?Promise.<!UI.SuggestBox.Suggestions>}
*/
_cssSuggestions(prefixRange, substituteRange) {
- var prefix = this._textEditor.text(prefixRange);
+ var prefix = this.textEditor.text(prefixRange);
if (prefix.startsWith('$'))
return null;
@@ -325,7 +325,7 @@ Sources.CSSSourceFrame = class extends Sources.UISourceCodeFrame {
if (!propertyToken)
return null;
- var line = this._textEditor.line(prefixRange.startLine);
+ var line = this.textEditor.line(prefixRange.startLine);
var tokenContent = line.substring(propertyToken.startColumn, propertyToken.endColumn);
var propertyValues = SDK.cssMetadata().propertyValues(tokenContent);
return Promise.resolve(propertyValues.filter(value => value.startsWith(prefix)).map(value => ({title: value})));
@@ -339,11 +339,11 @@ Sources.CSSSourceFrame = class extends Sources.UISourceCodeFrame {
_backtrackPropertyToken(lineNumber, columnNumber) {
var backtrackDepth = 10;
var tokenPosition = columnNumber;
- var line = this._textEditor.line(lineNumber);
+ var line = this.textEditor.line(lineNumber);
var seenColon = false;
for (var i = 0; i < backtrackDepth && tokenPosition >= 0; ++i) {
- var token = this._textEditor.tokenAtTextPosition(lineNumber, tokenPosition);
+ var token = this.textEditor.tokenAtTextPosition(lineNumber, tokenPosition);
if (!token)
return null;
if (token.type === 'css-property')

Powered by Google App Engine
This is Rietveld 408576698