third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js - Issue 2567573002: DevTools: fix private field usage violation discovered after the compiler roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js

Issue 2567573002: DevTools: fix private field usage violation discovered after the compiler roll. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js

index fac023b50059e432585de098d809fa029f1fbe76..37cca1190dfe78c68ccd2cb2eb142b308f889bc3 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js

@@ -55,7 +55,7 @@ TimelineModel.TracingLayerTree = class extends SDK.LayerTreeBase {

for (var i = 0; i < layers.length; ++i)

this._extractNodeIdsToResolve(idsToResolve, {}, layers[i]);

}

- this._resolveBackendNodeIds(idsToResolve, onBackendNodeIdsResolved.bind(this));

+ this.resolveBackendNodeIds(idsToResolve, onBackendNodeIdsResolved.bind(this));

/**

* @this {TimelineModel.TracingLayerTree}

@@ -132,7 +132,7 @@ TimelineModel.TracingLayerTree = class extends SDK.LayerTreeBase {

layer = new TimelineModel.TracingLayer(this.target(), payload);

this._layersById[payload.layer_id] = layer;

if (payload.owner_node)

- layer._setNode(this._backendNodeIdToNode.get(payload.owner_node) || null);

+ layer._setNode(this.backendNodeIdToNode().get(payload.owner_node) || null);

if (!this.contentRoot() && layer.drawsContent())

this.setContentRoot(layer);

for (var i = 0; payload.children && i < payload.children.length; ++i)

@@ -147,7 +147,7 @@ TimelineModel.TracingLayerTree = class extends SDK.LayerTreeBase {

_extractNodeIdsToResolve(nodeIdsToResolve, seenNodeIds, payload) {

var backendNodeId = payload.owner_node;

- if (backendNodeId && !this._backendNodeIdToNode.has(backendNodeId))

+ if (backendNodeId && !this.backendNodeIdToNode().has(backendNodeId))

nodeIdsToResolve.add(backendNodeId);

for (var i = 0; payload.children && i < payload.children.length; ++i)

this._extractNodeIdsToResolve(nodeIdsToResolve, seenNodeIds, payload.children[i]);