Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2567573002: DevTools: fix private field usage violation discovered after the compiler roll. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
index dbe32f3500d1a7ca539fc5e5d6943a2d8a925d01..4b037003182878ab15764f931dc2e9be22a4a4d9 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
@@ -532,7 +532,7 @@ Elements.ElementsTreeElement = class extends TreeElement {
if (this.treeOutline.selectedDOMNode() !== this._node)
return;
- var listItem = this._listItemNode;
+ var listItem = this.listItemElement;
if (this._canAddAttributes) {
var attribute = listItem.getElementsByClassName('webkit-html-attribute')[0];
@@ -749,8 +749,8 @@ Elements.ElementsTreeElement = class extends TreeElement {
child = child.nextSibling;
}
// Hide children item.
- if (this._childrenListNode)
- this._childrenListNode.style.display = 'none';
+ if (this.childrenListElement)
+ this.childrenListElement.style.display = 'none';
// Append editor.
this.listItemElement.appendChild(this._htmlEditElement);
this.listItemElement.classList.add('editing-as-html');
@@ -779,8 +779,8 @@ Elements.ElementsTreeElement = class extends TreeElement {
this.listItemElement.removeChild(this._htmlEditElement);
delete this._htmlEditElement;
// Unhide children item.
- if (this._childrenListNode)
- this._childrenListNode.style.removeProperty('display');
+ if (this.childrenListElement)
+ this.childrenListElement.style.removeProperty('display');
// Unhide header items.
var child = this.listItemElement.firstChild;
while (child) {
@@ -961,7 +961,7 @@ Elements.ElementsTreeElement = class extends TreeElement {
// For an expanded element, it will be the last element with class "close"
// in the child element list.
if (this.expanded) {
- var closers = this._childrenListNode.querySelectorAll('.close');
+ var closers = this.childrenListElement.querySelectorAll('.close');
return closers[closers.length - 1];
}

Powered by Google App Engine
This is Rietveld 408576698