Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2563983002: Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missin… (Closed)

Created:
4 years ago by kustermann
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missing CTEs from dartk and from dart_bootstrap R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/6a30db59976e8a770b73fe3c6691605eab7b1f3e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -209 lines) Patch
M tests/co19/co19-kernel.status View 5 chunks +35 lines, -106 lines 1 comment Download
M tests/language/language_kernel.status View 3 chunks +39 lines, -95 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +1 line, -6 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
https://codereview.chromium.org/2563983002/diff/1/tests/co19/co19-kernel.status File tests/co19/co19-kernel.status (left): https://codereview.chromium.org/2563983002/diff/1/tests/co19/co19-kernel.status#oldcode192 tests/co19/co19-kernel.status:192: Language/Libraries_and_Scripts/definition_syntax_t01: DartkMissingCompileTimeError Rietveld is incapable of showing the diff ...
4 years ago (2016-12-09 09:16:22 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years ago (2016-12-09 09:31:28 UTC) #3
kustermann
4 years ago (2016-12-09 09:55:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a30db59976e8a770b73fe3c6691605eab7b1f3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698