Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: tools/testing/dart/status_file_parser.dart

Issue 2563983002: Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missin… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library status_file_parser; 5 library status_file_parser;
6 6
7 import "dart:async"; 7 import "dart:async";
8 import "dart:convert" show LineSplitter, UTF8; 8 import "dart:convert" show LineSplitter, UTF8;
9 import "dart:io"; 9 import "dart:io";
10 10
(...skipping 16 matching lines...) Expand all
27 static Expectation STATIC_WARNING = byName('StaticWarning'); 27 static Expectation STATIC_WARNING = byName('StaticWarning');
28 static Expectation MISSING_STATIC_WARNING = byName('MissingStaticWarning'); 28 static Expectation MISSING_STATIC_WARNING = byName('MissingStaticWarning');
29 static Expectation PUB_GET_ERROR = byName('PubGetError'); 29 static Expectation PUB_GET_ERROR = byName('PubGetError');
30 30
31 // Special 'CRASH' cases 31 // Special 'CRASH' cases
32 static Expectation DARTK_CRASH = byName('DartkCrash'); 32 static Expectation DARTK_CRASH = byName('DartkCrash');
33 33
34 // Special 'TIMEOUT' cases 34 // Special 'TIMEOUT' cases
35 static Expectation DARTK_TIMEOUT = byName('DartkTimeout'); 35 static Expectation DARTK_TIMEOUT = byName('DartkTimeout');
36 36
37 // Special 'MISSING_COMPILETIME_ERROR'
38 static Expectation DARTK_MISSING_COMPILETIME_ERROR =
39 byName('DartkMissingCompileTimeError');
40
41 // Special 'COMPILETIME_ERROR' 37 // Special 'COMPILETIME_ERROR'
42 static Expectation DARTK_COMPILETIME_ERROR = byName('DartkCompileTimeError'); 38 static Expectation DARTK_COMPILETIME_ERROR = byName('DartkCompileTimeError');
43 39
44 // "meta expectations" 40 // "meta expectations"
45 static Expectation OK = byName('Ok'); 41 static Expectation OK = byName('Ok');
46 static Expectation SLOW = byName('Slow'); 42 static Expectation SLOW = byName('Slow');
47 static Expectation SKIP = byName('Skip'); 43 static Expectation SKIP = byName('Skip');
48 static Expectation SKIP_SLOW = byName('SkipSlow'); 44 static Expectation SKIP_SLOW = byName('SkipSlow');
49 static Expectation SKIP_BY_DESIGN = byName('SkipByDesign'); 45 static Expectation SKIP_BY_DESIGN = byName('SkipByDesign');
50 46
(...skipping 22 matching lines...) Expand all
73 group: group, isMetaExpectation: isMetaExpectation); 69 group: group, isMetaExpectation: isMetaExpectation);
74 assert(!_AllExpectations.containsKey(expectation.name)); 70 assert(!_AllExpectations.containsKey(expectation.name));
75 return _AllExpectations[expectation.name] = expectation; 71 return _AllExpectations[expectation.name] = expectation;
76 } 72 }
77 73
78 var fail = build("Fail"); 74 var fail = build("Fail");
79 var crash = build("Crash"); 75 var crash = build("Crash");
80 var timeout = build("Timeout"); 76 var timeout = build("Timeout");
81 build("Pass"); 77 build("Pass");
82 78
83 var missingCompileError = build("MissingCompileTimeError", group: fail);
84 var compileError = build("CompileTimeError", group: fail); 79 var compileError = build("CompileTimeError", group: fail);
80 build("MissingCompileTimeError", group: fail);
85 build("MissingRuntimeError", group: fail); 81 build("MissingRuntimeError", group: fail);
86 build("RuntimeError", group: fail); 82 build("RuntimeError", group: fail);
87 83
88 // Dartk sub expectations 84 // Dartk sub expectations
89 build("DartkCrash", group: crash); 85 build("DartkCrash", group: crash);
90 build("DartkTimeout", group: timeout); 86 build("DartkTimeout", group: timeout);
91 build("DartkMissingCompileTimeError", group: missingCompileError);
92 build("DartkCompileTimeError", group: compileError); 87 build("DartkCompileTimeError", group: compileError);
93 88
94 build("MissingStaticWarning", group: fail); 89 build("MissingStaticWarning", group: fail);
95 build("StaticWarning", group: fail); 90 build("StaticWarning", group: fail);
96 91
97 build("PubGetError", group: fail); 92 build("PubGetError", group: fail);
98 93
99 var skip = build("Skip", isMetaExpectation: true); 94 var skip = build("Skip", isMetaExpectation: true);
100 build("SkipByDesign", isMetaExpectation: true); 95 build("SkipByDesign", isMetaExpectation: true);
101 build("SkipSlow", group: skip, isMetaExpectation: true); 96 build("SkipSlow", group: skip, isMetaExpectation: true);
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 } 353 }
359 regExps[i] = regExp; 354 regExps[i] = regExp;
360 } 355 }
361 _keyToRegExps[key] = regExps; 356 _keyToRegExps[key] = regExps;
362 }); 357 });
363 358
364 _regExpCache = null; 359 _regExpCache = null;
365 _preprocessed = true; 360 _preprocessed = true;
366 } 361 }
367 } 362 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698