tools/testing/dart/test_runner.dart - Issue 2563983002: Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2563983002: Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missin… (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index bc6be6491449219ff5f13c0576efd72a2ab3e535..3694509fd0e28ec2b5824a4ea6c16bf24192c0a9 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -1670,8 +1670,6 @@ class KernelCompilationCommandOutputImpl extends CompilationCommandOutputImpl {

return Expectation.DARTK_CRASH;

} else if (result.canBeOutcomeOf(Expectation.TIMEOUT)) {

return Expectation.DARTK_TIMEOUT;

- } else if (result.canBeOutcomeOf(Expectation.MISSING_COMPILETIME_ERROR)) {

- return Expectation.DARTK_MISSING_COMPILETIME_ERROR;

} else if (result.canBeOutcomeOf(Expectation.COMPILETIME_ERROR)) {

return Expectation.DARTK_COMPILETIME_ERROR;

}