Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 2563983002: Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missin… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1652 matching lines...) Expand 10 before | Expand all | Expand 10 after
1663 // there were compile-time errors. See kernel_sdk issue #18. 1663 // there were compile-time errors. See kernel_sdk issue #18.
1664 return !hasCrashed && !timedOut && exitCode == 0; 1664 return !hasCrashed && !timedOut && exitCode == 0;
1665 } 1665 }
1666 1666
1667 Expectation result(TestCase testCase) { 1667 Expectation result(TestCase testCase) {
1668 Expectation result = super.result(testCase); 1668 Expectation result = super.result(testCase);
1669 if (result.canBeOutcomeOf(Expectation.CRASH)) { 1669 if (result.canBeOutcomeOf(Expectation.CRASH)) {
1670 return Expectation.DARTK_CRASH; 1670 return Expectation.DARTK_CRASH;
1671 } else if (result.canBeOutcomeOf(Expectation.TIMEOUT)) { 1671 } else if (result.canBeOutcomeOf(Expectation.TIMEOUT)) {
1672 return Expectation.DARTK_TIMEOUT; 1672 return Expectation.DARTK_TIMEOUT;
1673 } else if (result.canBeOutcomeOf(Expectation.MISSING_COMPILETIME_ERROR)) {
1674 return Expectation.DARTK_MISSING_COMPILETIME_ERROR;
1675 } else if (result.canBeOutcomeOf(Expectation.COMPILETIME_ERROR)) { 1673 } else if (result.canBeOutcomeOf(Expectation.COMPILETIME_ERROR)) {
1676 return Expectation.DARTK_COMPILETIME_ERROR; 1674 return Expectation.DARTK_COMPILETIME_ERROR;
1677 } 1675 }
1678 return result; 1676 return result;
1679 } 1677 }
1680 1678
1681 // If the compiler was able to produce a Kernel IR file we want to run the 1679 // If the compiler was able to produce a Kernel IR file we want to run the
1682 // result on the Dart VM. We therefore mark the [KernelCompilationCommand] as 1680 // result on the Dart VM. We therefore mark the [KernelCompilationCommand] as
1683 // successful. 1681 // successful.
1684 // => This ensures we test that the DartVM produces correct CompileTime errors 1682 // => This ensures we test that the DartVM produces correct CompileTime errors
(...skipping 1469 matching lines...) Expand 10 before | Expand all | Expand 10 after
3154 } 3152 }
3155 } 3153 }
3156 3154
3157 void eventAllTestsDone() { 3155 void eventAllTestsDone() {
3158 for (var listener in _eventListener) { 3156 for (var listener in _eventListener) {
3159 listener.allDone(); 3157 listener.allDone();
3160 } 3158 }
3161 _allDone(); 3159 _allDone();
3162 } 3160 }
3163 } 3161 }
OLDNEW
« tests/co19/co19-kernel.status ('K') | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698