Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 2563983002: Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missin… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/status_file_parser.dart
diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart
index a26c792b37d24f782281d1a8737dab37c881d5d7..3ede28c28e80eab93c108d0aabb9255de5977551 100644
--- a/tools/testing/dart/status_file_parser.dart
+++ b/tools/testing/dart/status_file_parser.dart
@@ -34,10 +34,6 @@ class Expectation {
// Special 'TIMEOUT' cases
static Expectation DARTK_TIMEOUT = byName('DartkTimeout');
- // Special 'MISSING_COMPILETIME_ERROR'
- static Expectation DARTK_MISSING_COMPILETIME_ERROR =
- byName('DartkMissingCompileTimeError');
-
// Special 'COMPILETIME_ERROR'
static Expectation DARTK_COMPILETIME_ERROR = byName('DartkCompileTimeError');
@@ -80,15 +76,14 @@ class Expectation {
var timeout = build("Timeout");
build("Pass");
- var missingCompileError = build("MissingCompileTimeError", group: fail);
var compileError = build("CompileTimeError", group: fail);
+ build("MissingCompileTimeError", group: fail);
build("MissingRuntimeError", group: fail);
build("RuntimeError", group: fail);
// Dartk sub expectations
build("DartkCrash", group: crash);
build("DartkTimeout", group: timeout);
- build("DartkMissingCompileTimeError", group: missingCompileError);
build("DartkCompileTimeError", group: compileError);
build("MissingStaticWarning", group: fail);

Powered by Google App Engine
This is Rietveld 408576698