Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 256373002: Turn on quilt mode in DM. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Turn on quilt mode in DM. - Rename TileGrid -> Quilt to avoid the name overload. - Tag all failing GMs with kSkipTiled_Flag. You may be wondering, do any GMs pass? Yes, some do! And that trends towards all of them as we increase --quiltTile. Two GMs only fail in --quilt mode in 565. Otherwise all GMs which fail are skipped, and those which don't fail aren't. (The 8888 variants of those two GMs are skipped even though they pass.) BUG=skia:2477 Committed: http://code.google.com/p/skia/source/detail?r=14457

Patch Set 1 #

Patch Set 2 : simpler qulit #

Patch Set 3 : more #

Patch Set 4 : back off false positives #

Patch Set 5 : batch #

Patch Set 6 : simplify #

Patch Set 7 : batch #

Patch Set 8 : rest #

Patch Set 9 : tidy #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+483 lines, -172 lines) Patch
M dm/DMCpuGMTask.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + dm/DMQuiltTask.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + dm/DMQuiltTask.cpp View 1 2 3 4 5 6 7 8 3 chunks +12 lines, -25 lines 0 comments Download
D dm/DMTileGridTask.h View 1 chunk +0 lines, -35 lines 0 comments Download
D dm/DMTileGridTask.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
M gm/aarectmodes.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M gm/alphagradients.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gm/arcofzorro.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bicubicfilter.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bigmatrix.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bigtext.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bitmapmatrix.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bitmaprecttest.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bitmapscroll.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bitmapshader.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bleed.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/blurrect.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gm/blurroundrect.cpp View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M gm/blurs.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/circles.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/circularclips.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/coloremoji.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/colorfilters.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/complexclip.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/complexclip2.cpp View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M gm/composeshader.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/convexpaths.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/convexpolyclip.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M gm/cubicpaths.cpp View 1 2 3 4 5 6 7 3 chunks +12 lines, -0 lines 0 comments Download
M gm/dashcubics.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/dashing.cpp View 1 2 3 4 5 6 7 3 chunks +12 lines, -0 lines 0 comments Download
M gm/degeneratesegments.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/downsamplebitmap.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M gm/drawlooper.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M gm/drrect.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/fatpathfill.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/filltypes.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/filltypespersp.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/filterbitmap.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/fontscaler.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/getpostextpath.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/giantbitmap.cpp View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M gm/gradientDirtyLaundry.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/gradient_matrix.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/gradients.cpp View 1 2 5 chunks +20 lines, -0 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M gm/gradients_no_texture.cpp View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M gm/gradtext.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/hairlines.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/hairmodes.cpp View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
M gm/hittestpath.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/imageblur.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/imagefiltersbase.cpp View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/imageresizetiled.cpp View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M gm/inversepaths.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gm/lerpmode.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/lighting.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gm/linepaths.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/lumafilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/mixedxfermodes.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M gm/nested.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/nonclosedpaths.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gm/ovals.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/patheffects.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/pathfill.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M gm/pathinterior.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/pathopsinverse.cpp View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M gm/pathopsskpclip.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/pathreverse.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gm/pictureshader.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gm/points.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/poly2poly.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/polygons.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/quadpaths.cpp View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M gm/rects.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/resizeimagefilter.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/roundrects.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/rrect.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/samplerstress.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/shaderbounds.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/shadertext.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M gm/shadertext2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext3.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M gm/shadows.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/shallowgradient.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M gm/simpleaaclip.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M gm/skbug1719.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/spritebitmap.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/stringart.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/strokefill.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M gm/strokerect.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/strokerects.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/strokes.cpp View 3 chunks +12 lines, -0 lines 0 comments Download
M gm/stroketext.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/testimagefilters.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/thinstrokedrects.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/tilemodes.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 1 2 3 4 5 6 7 2 chunks +11 lines, -1 line 0 comments Download
M gm/twopointradial.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/vertices.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/verttext.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/verttext2.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/dm.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 7 months ago (2014-04-29 19:46:57 UTC) #1
reed1
What is the tolerance for "passing"? Is that settable so we can sort the failing ...
6 years, 7 months ago (2014-04-30 12:11:54 UTC) #2
mtklein
On 2014/04/30 12:11:54, reed1 wrote: > What is the tolerance for "passing"? Is that settable ...
6 years, 7 months ago (2014-04-30 12:22:44 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-04-30 12:22:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/256373002/170001
6 years, 7 months ago (2014-04-30 12:23:06 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 13:21:36 UTC) #6
Message was sent while issue was closed.
Change committed as 14457

Powered by Google App Engine
This is Rietveld 408576698