Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: dm/DMQuiltTask.cpp

Issue 256373002: Turn on quilt mode in DM. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMQuiltTask.h ('k') | dm/DMTileGridTask.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMQuiltTask.cpp
diff --git a/dm/DMTileGridTask.cpp b/dm/DMQuiltTask.cpp
similarity index 56%
rename from dm/DMTileGridTask.cpp
rename to dm/DMQuiltTask.cpp
index 4299bd7985f221b6a8b41ef3d7bceef13533cdd6..e8f8b60a0f7cd37d83915fae5ab0bf53ad727001 100644
--- a/dm/DMTileGridTask.cpp
+++ b/dm/DMQuiltTask.cpp
@@ -1,51 +1,38 @@
-#include "DMTileGridTask.h"
-#include "DMWriteTask.h"
+#include "DMQuiltTask.h"
#include "DMUtil.h"
+#include "DMWriteTask.h"
-#include "SkBBHFactory.h"
#include "SkCommandLineFlags.h"
#include "SkPicture.h"
-// TODO(mtklein): Tile grid tests are currently failing. (Skia issue 1198). When fixed, -> true.
-DEFINE_bool(tileGrid, false, "If true, run picture replay tests with a tile grid.");
+DEFINE_bool(quilt, true, "If true, draw into a quilt of small tiles and compare.");
+DEFINE_int32(quiltTile, 16, "Dimension of (square) quilt tile.");
namespace DM {
-TileGridTask::TileGridTask(const Task& parent, skiagm::GM* gm, SkBitmap reference, SkISize tileSize)
+QuiltTask::QuiltTask(const Task& parent, skiagm::GM* gm, SkBitmap reference)
: CpuTask(parent)
- , fName(UnderJoin(parent.name().c_str(), "tilegrid"))
+ , fName(UnderJoin(parent.name().c_str(), "quilt"))
, fGM(gm)
, fReference(reference)
- , fTileSize(tileSize)
{}
static int tiles_needed(int fullDimension, int tileDimension) {
return (fullDimension + tileDimension - 1) / tileDimension;
}
-void TileGridTask::draw() {
- const SkTileGridFactory::TileGridInfo info = {
- fTileSize,
- SkISize::Make(0,0), // Overlap between adjacent tiles.
- SkIPoint::Make(0,0), // Offset.
- };
- SkTileGridFactory factory(info);
- SkAutoTUnref<SkPicture> recorded(RecordPicture(fGM.get(),
- SkPicture::kUsePathBoundsForClip_RecordingFlag,
- &factory));
+void QuiltTask::draw() {
+ SkAutoTUnref<SkPicture> recorded(RecordPicture(fGM.get()));
SkBitmap full;
SetupBitmap(fReference.colorType(), fGM.get(), &full);
SkCanvas fullCanvas(full);
SkBitmap tile;
- tile.allocPixels(SkImageInfo::Make(fTileSize.width(), fTileSize.height(),
+ tile.allocPixels(SkImageInfo::Make(FLAGS_quiltTile, FLAGS_quiltTile,
fReference.colorType(), kPremul_SkAlphaType));
SkCanvas tileCanvas(tile);
- SkPaint paint;
- paint.setXfermodeMode(SkXfermode::kSrc_Mode);
-
for (int y = 0; y < tiles_needed(full.height(), tile.height()); y++) {
for (int x = 0; x < tiles_needed(full.width(), tile.width()); x++) {
SkAutoCanvasRestore ar(&tileCanvas, true/*also save now*/);
@@ -58,7 +45,7 @@ void TileGridTask::draw() {
recorded->draw(&tileCanvas);
tileCanvas.flush();
- fullCanvas.drawBitmap(tile, xOffset, yOffset, &paint);
+ fullCanvas.drawBitmap(tile, xOffset, yOffset, NULL);
}
}
@@ -68,14 +55,14 @@ void TileGridTask::draw() {
}
}
-bool TileGridTask::shouldSkip() const {
+bool QuiltTask::shouldSkip() const {
if (fGM->getFlags() & skiagm::GM::kSkipPicture_Flag) {
return true;
}
if (fGM->getFlags() & skiagm::GM::kSkipTiled_Flag) {
return true;
}
- return !FLAGS_tileGrid;
+ return !FLAGS_quilt;
}
} // namespace DM
« no previous file with comments | « dm/DMQuiltTask.h ('k') | dm/DMTileGridTask.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698