Disallow [in]equality operator for PageTransition

Disallow [in]equality operator for PageTransition

Direct comparison of the enum is error-prone since users can easily
forget about the qualifier bits. The available helper functions should
be used instead as documented in the comment.

Most occurrences were addressed in earlier patches and a few leftovers
are updated here, together with the change in page_transition_types.h
that causes compiler errors if [in]equality operator is used for the
enum.

BUG=

Committed: https://crrev.com/1b34e0ef500c487ac6294ab36efb640195d32aee
Cr-Commit-Position: refs/heads/master@{#439079}

[mastiz, 2016-12-09 11:27:10]

The CQ bit was checked by mastiz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 11:27:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 11:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 11:37:52]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mastiz, 2016-12-09 12:09:56]

The CQ bit was checked by mastiz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 12:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 12:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 12:27:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mastiz, 2016-12-09 12:38:51]

The CQ bit was checked by mastiz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 12:39:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 13:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 13:19:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mastiz, 2016-12-13 10:02:05]

The CQ bit was checked by mastiz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 10:02:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 11:14:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 11:14:04]

Dry run: This issue passed the CQ dry run.

[mastiz, 2016-12-13 12:24:16]

mastiz@chromium.org changed reviewers:
+ sky@chromium.org

[mastiz, 2016-12-13 12:24:17]

Longstanding patch, including some client-code updates that my earlier patches
missed. Let me know if I should split them into dedicated patches, thx.

[sky, 2016-12-13 14:16:06]

LGTM

[mastiz, 2016-12-14 20:18:11]

mastiz@chromium.org changed reviewers:
+ jam@chromium.org

[mastiz, 2016-12-14 20:18:12]

jam@chromium.org: Please review changes in components/ and ios/

[jam, 2016-12-15 20:19:43]

lgtm

[mastiz, 2016-12-16 08:36:01]

The CQ bit was checked by mastiz@chromium.org

[commit-bot: I haz the power, 2016-12-16 08:36:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 09:49:38]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481877361987880,
"parent_rev": "a62af02df00a5d61bf2f8a23f1f6e10877c637c2", "commit_rev":
"ec9c5c46a16dcdfe7da91d4b5a130a6bb8bcd410"}

[commit-bot: I haz the power, 2016-12-16 09:50:03]

Description was changed from

==========
Disallow [in]equality operator for PageTransition

Direct comparison of the enum is error-prone since users can easily
forget about the qualifier bits. The available helper functions should
be used instead as documented in the comment.

Most occurrences were addressed in earlier patches and a few leftovers
are updated here, together with the change in page_transition_types.h
that causes compiler errors if [in]equality operator is used for the
enum.

BUG=
==========

to

==========
Disallow [in]equality operator for PageTransition

Direct comparison of the enum is error-prone since users can easily
forget about the qualifier bits. The available helper functions should
be used instead as documented in the comment.

Most occurrences were addressed in earlier patches and a few leftovers
are updated here, together with the change in page_transition_types.h
that causes compiler errors if [in]equality operator is used for the
enum.

BUG=

Review-Url: https://codereview.chromium.org/2562993002
==========

[commit-bot: I haz the power, 2016-12-16 09:50:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-16 09:53:40]

Description was changed from

==========
Disallow [in]equality operator for PageTransition

Direct comparison of the enum is error-prone since users can easily
forget about the qualifier bits. The available helper functions should
be used instead as documented in the comment.

Most occurrences were addressed in earlier patches and a few leftovers
are updated here, together with the change in page_transition_types.h
that causes compiler errors if [in]equality operator is used for the
enum.

BUG=

Review-Url: https://codereview.chromium.org/2562993002
==========

to

==========
Disallow [in]equality operator for PageTransition

Direct comparison of the enum is error-prone since users can easily
forget about the qualifier bits. The available helper functions should
be used instead as documented in the comment.

Most occurrences were addressed in earlier patches and a few leftovers
are updated here, together with the change in page_transition_types.h
that causes compiler errors if [in]equality operator is used for the
enum.

BUG=

Committed: https://crrev.com/1b34e0ef500c487ac6294ab36efb640195d32aee
Cr-Commit-Position: refs/heads/master@{#439079}
==========

[commit-bot: I haz the power, 2016-12-16 09:53:41]

Patchset 5 (id:??) landed as
https://crrev.com/1b34e0ef500c487ac6294ab36efb640195d32aee
Cr-Commit-Position: refs/heads/master@{#439079}