Disallow [in]equality operator for PageTransition

components/arc/intent_helper/page_transition_util_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/intent_helper/page_transition_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/page_transition_types.h"
 
 namespace arc {
 
@@ skipping 31 matching lines @@
   EXPECT_TRUE(ShouldIgnoreNavigation(ui::PAGE_TRANSITION_RELOAD, false, false));
   EXPECT_TRUE(ShouldIgnoreNavigation(ui::PAGE_TRANSITION_RELOAD, true, true));
   EXPECT_TRUE(
       ShouldIgnoreNavigation(ui::PAGE_TRANSITION_KEYWORD, false, false));
   EXPECT_TRUE(ShouldIgnoreNavigation(ui::PAGE_TRANSITION_KEYWORD, true, true));
   EXPECT_TRUE(ShouldIgnoreNavigation(ui::PAGE_TRANSITION_KEYWORD_GENERATED,
                                      false, false));
   EXPECT_TRUE(ShouldIgnoreNavigation(ui::PAGE_TRANSITION_KEYWORD_GENERATED,
                                      true, true));
 
-  static_assert(
-      ui::PAGE_TRANSITION_KEYWORD_GENERATED == ui::PAGE_TRANSITION_LAST_CORE,
-      "Not all core transition types are covered here");
+  static_assert(static_cast<int32_t>(ui::PAGE_TRANSITION_KEYWORD_GENERATED) ==
+                    static_cast<int32_t>(ui::PAGE_TRANSITION_LAST_CORE),
+                "Not all core transition types are covered here");
 }
 
 // Tests that ShouldIgnoreNavigation returns true when no qualifiers except
 // server redirect are provided.
 TEST(PageTransitionUtilTest, TestShouldIgnoreNavigationWithLinkWithQualifiers) {
   // The navigation is triggered by Forward or Back button.
   EXPECT_TRUE(ShouldIgnoreNavigation(
       ui::PageTransitionFromInt(ui::PAGE_TRANSITION_LINK |
                                 ui::PAGE_TRANSITION_FORWARD_BACK),
       false, false));
@@ skipping 101 matching lines @@
       ui::PageTransitionFromInt(ui::PAGE_TRANSITION_LINK |
                                 ui::PAGE_TRANSITION_HOME_PAGE),
       true, true));
 }
 
 // Test that MaskOutPageTransition correctly remove a qualifier from a given
 // |page_transition|.
 TEST(PageTransitionUtilTest, TestMaskOutPageTransition) {
   ui::PageTransition page_transition = ui::PageTransitionFromInt(
       ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_CLIENT_REDIRECT);
-  EXPECT_EQ(ui::PAGE_TRANSITION_LINK,
-            MaskOutPageTransition(page_transition,
-                                  ui::PAGE_TRANSITION_CLIENT_REDIRECT));
+  EXPECT_EQ(static_cast<int>(ui::PAGE_TRANSITION_LINK),
+            static_cast<int>(MaskOutPageTransition(
+                page_transition, ui::PAGE_TRANSITION_CLIENT_REDIRECT)));
 
   page_transition = ui::PageTransitionFromInt(
       ui::PAGE_TRANSITION_LINK | ui::PAGE_TRANSITION_SERVER_REDIRECT);
-  EXPECT_EQ(ui::PAGE_TRANSITION_LINK,
-            MaskOutPageTransition(page_transition,
-                                  ui::PAGE_TRANSITION_SERVER_REDIRECT));
+  EXPECT_EQ(static_cast<int>(ui::PAGE_TRANSITION_LINK),
+            static_cast<int>(MaskOutPageTransition(
+                page_transition, ui::PAGE_TRANSITION_SERVER_REDIRECT)));
 }
 
 // Test mixed variants between |allow_form_submit| and |allow_client_redirect|.
 TEST(PageTransitionUtilTest, TestShouldIgnoreNavigationWithNonProdScenarios) {
   EXPECT_FALSE(ShouldIgnoreNavigation(ui::PAGE_TRANSITION_LINK, true, false));
   EXPECT_FALSE(ShouldIgnoreNavigation(ui::PAGE_TRANSITION_LINK, false, true));
 
   EXPECT_TRUE(ShouldIgnoreNavigation(
       ui::PageTransitionFromInt(ui::PAGE_TRANSITION_LINK |
                                 ui::PAGE_TRANSITION_CLIENT_REDIRECT),
@@ skipping 12 matching lines @@
       ui::PageTransitionFromInt(ui::PAGE_TRANSITION_FORM_SUBMIT |
                                 ui::PAGE_TRANSITION_CLIENT_REDIRECT),
       true, false));
   EXPECT_TRUE(ShouldIgnoreNavigation(
       ui::PageTransitionFromInt(ui::PAGE_TRANSITION_FORM_SUBMIT |
                                 ui::PAGE_TRANSITION_CLIENT_REDIRECT),
       false, true));
 }
 
 }  // namespace arc