chrome/browser/net/net_error_tab_helper.cc - Issue 2562993002: Disallow [in]equality operator for PageTransition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/net_error_tab_helper.cc

Issue 2562993002: Disallow [in]equality operator for PageTransition (Closed)

Patch Set: Disallow [in]equality operator for PageTransition Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/net_error_tab_helper.cc

diff --git a/chrome/browser/net/net_error_tab_helper.cc b/chrome/browser/net/net_error_tab_helper.cc

index c3c977da64ebae60c594bcc0a210585538fbfb61..8b257b5fa2b42ac9f24499fff870ef4f334f88c8 100644

--- a/chrome/browser/net/net_error_tab_helper.cc

+++ b/chrome/browser/net/net_error_tab_helper.cc

@@ -102,7 +102,8 @@ void NetErrorTabHelper::DidStartNavigation(

return;

if (navigation_handle->IsErrorPage() &&

- navigation_handle->GetPageTransition() == ui::PAGE_TRANSITION_RELOAD) {

+ PageTransitionCoreTypeIs(navigation_handle->GetPageTransition(),

+ ui::PAGE_TRANSITION_RELOAD)) {

error_page::RecordEvent(

error_page::NETWORK_ERROR_PAGE_BROWSER_INITIATED_RELOAD);

}