ios/web/web_state/ui/crw_web_controller.mm - Issue 2562993002: Disallow [in]equality operator for PageTransition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2562993002: Disallow [in]equality operator for PageTransition (Closed)

Patch Set: Disallow [in]equality operator for PageTransition Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index ca23114424b25110cd961183512fc18ee9f53b60..f83a4ad2fc1630a495793bb62890bb3122d6112a 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -3400,7 +3400,8 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

!_webStateImpl->GetNavigationManager()->GetItemCount();

BOOL isPossibleLinkClick = [self isLinkNavigation:action.navigationType];

if (isPossibleLinkClick || isOpenInNewTabNavigation ||

- [self currentTransition] == ui::PAGE_TRANSITION_AUTO_BOOKMARK) {

+ PageTransitionCoreTypeIs([self currentTransition],

+ ui::PAGE_TRANSITION_AUTO_BOOKMARK)) {

// Check If the URL is handled by a native app.

if ([self urlTriggersNativeAppLaunch:requestURL

sourceURL:[self currentNavigationURL]

« no previous file with comments | « content/test/test_render_frame_host.cc ('k') | ui/base/page_transition_types.h » ('j') | no next file with comments »