Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: net/socket/client_socket_handle.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_handle.cc
diff --git a/net/socket/client_socket_handle.cc b/net/socket/client_socket_handle.cc
index be58c7296d62c1b763888f0392edb43174f1a931..10f36fbbcbcb3fdabab7c8cf64d3f7106330e706 100644
--- a/net/socket/client_socket_handle.cc
+++ b/net/socket/client_socket_handle.cc
@@ -165,7 +165,8 @@ void ClientSocketHandle::HandleInitCompletion(int result) {
return;
}
is_initialized_ = true;
- CHECK_NE(-1, pool_id_) << "Pool should have set |pool_id_| to a valid value.";
+ // Pool should have set |pool_id_| to a valid value.
+ CHECK_NE(-1, pool_id_);
// Broadcast that the socket has been acquired.
// TODO(eroman): This logging is not complete, in particular set_socket() and

Powered by Google App Engine
This is Rietveld 408576698