Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: remoting/host/curtain_mode_mac.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/curtain_mode_mac.cc
diff --git a/remoting/host/curtain_mode_mac.cc b/remoting/host/curtain_mode_mac.cc
index a94e569f895f3c01184455c80f1cf4380d05494b..adc5b49917da5e83e1ec14662840e1d6caf61f87 100644
--- a/remoting/host/curtain_mode_mac.cc
+++ b/remoting/host/curtain_mode_mac.cc
@@ -132,10 +132,9 @@ void SessionWatcher::ActivateCurtain() {
// this, or how common it is, a crash report is useful in this case (note
// that the connection would have to be refused in any case, so this is no
// loss of functionality).
- CHECK(session != nullptr)
- << "Error activating curtain-mode: "
- << "CGSessionCopyCurrentDictionary() returned NULL. "
- << "Logging out and back in should resolve this error.";
+ // Error activating curtain-mode: CGSessionCopyCurrentDictionary() returned
Sergey Ulanov 2016/12/11 23:11:45 This comment would be confusing, especially given
dcheng 2016/12/11 23:15:03 We've landed a change which should make this CL un
+ // NULL. Logging out and back in should resolve this error.
+ CHECK(session != nullptr);
const void* on_console = CFDictionaryGetValue(session,
kCGSessionOnConsoleKey);

Powered by Google App Engine
This is Rietveld 408576698