Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/autofill/form_structure_browsertest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/form_structure_browsertest.cc
diff --git a/chrome/browser/autofill/form_structure_browsertest.cc b/chrome/browser/autofill/form_structure_browsertest.cc
index 4a77401161403f5e33acc874517d54383d39a80b..e73743414ed359cd1c9bf491c882b93bffb78dcd 100644
--- a/chrome/browser/autofill/form_structure_browsertest.cc
+++ b/chrome/browser/autofill/form_structure_browsertest.cc
@@ -38,7 +38,8 @@ const base::FilePath::CharType kTestName[] = FILE_PATH_LITERAL("heuristics");
// Convert the |html| snippet to a data URI.
GURL HTMLToDataURI(const std::string& html) {
// GURL requires data URLs to be UTF-8 and will fail below if it's not.
- CHECK(base::IsStringUTF8(html)) << "Input file is not UTF-8.";
+ // Input file is not UTF-8.
vabr (Chromium) 2016/12/09 08:29:12 This comment does not make sense. Thanks to the Is
+ CHECK(base::IsStringUTF8(html));
return GURL(std::string("data:text/html;charset=utf-8,") + html);
}

Powered by Google App Engine
This is Rietveld 408576698