Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: net/quic/test_tools/quic_test_utils.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/test_tools/quic_test_utils.cc
diff --git a/net/quic/test_tools/quic_test_utils.cc b/net/quic/test_tools/quic_test_utils.cc
index bf4055dd76bb69ee98f56391e5d3463d3fad428b..7ca65ee8288f38f57001a31e07fc1eaf3fe32c97 100644
--- a/net/quic/test_tools/quic_test_utils.cc
+++ b/net/quic/test_tools/quic_test_utils.cc
@@ -84,10 +84,9 @@ QuicPacket* BuildUnsizedDataPacket(QuicFramer* framer,
}
QuicFlagSaver::QuicFlagSaver() {
-#define QUIC_FLAG(type, flag, value) \
- CHECK_EQ(value, flag) << "Flag set to an expected value. A prior test is " \
- "likely setting a flag " \
- << "without using a QuicFlagSaver";
+// This checks that |flag| is set to an expected value. A prior test is
+// likely setting a flag without using a QuicFlagSaver if this fails.
+#define QUIC_FLAG(type, flag, value) CHECK_EQ(value, flag);
#include "net/quic/core/quic_flags_list.h"
#undef QUIC_FLAG
}
@@ -851,9 +850,9 @@ void CreateClientSessionForTest(QuicServerId server_id,
CHECK(crypto_client_config);
CHECK(client_connection);
CHECK(client_session);
- CHECK(!connection_start_time.IsZero())
- << "Connections must start at non-zero times, otherwise the "
- << "strike-register will be unhappy.";
+ // Connections must start at non-zero times, otherwise the strike-register
+ // will be unhappy.
+ CHECK(!connection_start_time.IsZero());
QuicConfig config = supports_stateless_rejects
? DefaultQuicConfigStatelessRejects()
@@ -878,9 +877,9 @@ void CreateServerSessionForTest(
CHECK(server_crypto_config);
CHECK(server_connection);
CHECK(server_session);
- CHECK(!connection_start_time.IsZero())
- << "Connections must start at non-zero times, otherwise the "
- << "strike-register will be unhappy.";
+ // Connections must start at non-zero times, otherwise the strike-register
+ // will be unhappy.
+ CHECK(!connection_start_time.IsZero());
*server_connection = new PacketSavingConnection(
helper, alarm_factory, Perspective::IS_SERVER, supported_versions);

Powered by Google App Engine
This is Rietveld 408576698