Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/sequenced_socket_data_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « net/socket/client_socket_handle.cc ('k') | net/socket/socket_test_util.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/sequenced_socket_data_unittest.cc
diff --git a/net/socket/sequenced_socket_data_unittest.cc b/net/socket/sequenced_socket_data_unittest.cc
index ea77f0a3e00cc4242281d9adea713f75d80aba8c..1d8212ad112634d690b9a29149a763e29b846bcf 100644
--- a/net/socket/sequenced_socket_data_unittest.cc
+++ b/net/socket/sequenced_socket_data_unittest.cc
@@ -106,8 +106,10 @@ class ReentrantHelper {
private:
void OnIOComplete(int rv) {
- CHECK_NE(-1, first_len_) << "Expectation not set.";
- CHECK_NE(-1, second_len_) << "Invocation not set.";
+ // Expectation not set.
+ CHECK_NE(-1, first_len_);
+ // Invocation not set.
+ CHECK_NE(-1, second_len_);
ASSERT_EQ(first_len_, rv);
if (verify_read_) {
ASSERT_EQ(std::string(first_read_data_, first_len_),
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « net/socket/client_socket_handle.cc ('k') | net/socket/socket_test_util.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698