Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: net/quic/test_tools/crypto_test_utils.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/test_tools/crypto_test_utils.cc
diff --git a/net/quic/test_tools/crypto_test_utils.cc b/net/quic/test_tools/crypto_test_utils.cc
index 0f756f0e7dd76ae9c9d403a4baa2e052b2a2db58..a9ff9a779af5b2f0670b4bccd011d97ceee4212e 100644
--- a/net/quic/test_tools/crypto_test_utils.cc
+++ b/net/quic/test_tools/crypto_test_utils.cc
@@ -588,7 +588,8 @@ class MockCommonCertSets : public CommonCertSets {
: cert_(cert.as_string()), hash_(hash), index_(index) {}
StringPiece GetCommonHashes() const override {
- CHECK(false) << "not implemented";
+ // not implemented
+ CHECK(false);
return StringPiece();
}
@@ -851,7 +852,8 @@ CryptoHandshakeMessage CryptoTestUtils::Message(const char* message_tag, ...) {
const int min_bytes = va_arg(ap, int);
msg.set_minimum_size(min_bytes);
} else {
- CHECK(false) << "Unknown special value: " << special;
+ // Unknown special value.
+ CHECK(false);
}
continue;

Powered by Google App Engine
This is Rietveld 408576698