Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: net/quic/core/quic_stream_sequencer_buffer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_stream_sequencer_buffer.cc
diff --git a/net/quic/core/quic_stream_sequencer_buffer.cc b/net/quic/core/quic_stream_sequencer_buffer.cc
index 6b3ee9d96aae51db637e8676d81a4993223d54a3..d472acc15533776d150f05891372256901fbf890 100644
--- a/net/quic/core/quic_stream_sequencer_buffer.cc
+++ b/net/quic/core/quic_stream_sequencer_buffer.cc
@@ -51,9 +51,9 @@ QuicStreamSequencerBuffer::QuicStreamSequencerBuffer(size_t max_capacity_bytes)
total_bytes_read_(0),
blocks_(nullptr),
destruction_indicator_(123456) {
- CHECK_GT(blocks_count_, 1u)
- << "blocks_count_ = " << blocks_count_
- << ", max_buffer_capacity_bytes_ = " << max_buffer_capacity_bytes_;
+ // blocks_count_ = |blocks_count_|, max_buffer_capacity_bytes_ =
+ // |max_buffer_capacity_bytes_|
+ CHECK_GT(blocks_count_, 1u);
Clear();
}
@@ -96,7 +96,8 @@ QuicErrorCode QuicStreamSequencerBuffer::OnStreamData(
QuicTime timestamp,
size_t* const bytes_buffered,
std::string* error_details) {
- CHECK_EQ(destruction_indicator_, 123456) << "This object has been destructed";
+ // This object has been destructed
+ CHECK_EQ(destruction_indicator_, 123456);
*bytes_buffered = 0;
QuicStreamOffset offset = starting_offset;
size_t size = data.size();
@@ -279,7 +280,8 @@ QuicErrorCode QuicStreamSequencerBuffer::Readv(const iovec* dest_iov,
size_t dest_count,
size_t* bytes_read,
string* error_details) {
- CHECK_EQ(destruction_indicator_, 123456) << "This object has been destructed";
+ // This object has been destructed
+ CHECK_EQ(destruction_indicator_, 123456);
*bytes_read = 0;
for (size_t i = 0; i < dest_count && ReadableBytes() > 0; ++i) {
@@ -338,7 +340,8 @@ QuicErrorCode QuicStreamSequencerBuffer::Readv(const iovec* dest_iov,
int QuicStreamSequencerBuffer::GetReadableRegions(struct iovec* iov,
int iov_count) const {
- CHECK_EQ(destruction_indicator_, 123456) << "This object has been destructed";
+ // This object has been destructed
+ CHECK_EQ(destruction_indicator_, 123456);
DCHECK(iov != nullptr);
DCHECK_GT(iov_count, 0);
@@ -398,7 +401,8 @@ int QuicStreamSequencerBuffer::GetReadableRegions(struct iovec* iov,
bool QuicStreamSequencerBuffer::GetReadableRegion(iovec* iov,
QuicTime* timestamp) const {
- CHECK_EQ(destruction_indicator_, 123456) << "This object has been destructed";
+ // This object has been destructed
+ CHECK_EQ(destruction_indicator_, 123456);
if (ReadableBytes() == 0) {
iov[0].iov_base = nullptr;
@@ -438,7 +442,8 @@ bool QuicStreamSequencerBuffer::GetReadableRegion(iovec* iov,
}
bool QuicStreamSequencerBuffer::MarkConsumed(size_t bytes_used) {
- CHECK_EQ(destruction_indicator_, 123456) << "This object has been destructed";
+ // This object has been destructed
+ CHECK_EQ(destruction_indicator_, 123456);
if (bytes_used > ReadableBytes()) {
return false;

Powered by Google App Engine
This is Rietveld 408576698