Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: mojo/edk/test/test_utils_win.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/test/test_utils_win.cc
diff --git a/mojo/edk/test/test_utils_win.cc b/mojo/edk/test/test_utils_win.cc
index 17bf5bbfa3ea4a9e1e31bb3cbdaccc9a06ab8a3d..d0253827b6359ac64c7b79c01234b17f5d83e9fe 100644
--- a/mojo/edk/test/test_utils_win.cc
+++ b/mojo/edk/test/test_utils_win.cc
@@ -83,11 +83,11 @@ ScopedPlatformHandle PlatformHandleFromFILE(base::ScopedFILE fp) {
CHECK(fp);
HANDLE rv = INVALID_HANDLE_VALUE;
- PCHECK(DuplicateHandle(
+ // DuplicateHandle
+ CHECK(DuplicateHandle(
GetCurrentProcess(),
reinterpret_cast<HANDLE>(_get_osfhandle(_fileno(fp.get()))),
- GetCurrentProcess(), &rv, 0, TRUE, DUPLICATE_SAME_ACCESS))
- << "DuplicateHandle";
+ GetCurrentProcess(), &rv, 0, TRUE, DUPLICATE_SAME_ACCESS));
return ScopedPlatformHandle(PlatformHandle(rv));
}
@@ -106,7 +106,8 @@ base::ScopedFILE FILEFromPlatformHandle(ScopedPlatformHandle h,
base::ScopedFILE rv(_fdopen(
_open_osfhandle(reinterpret_cast<intptr_t>(h.release().handle), flags),
mode));
- PCHECK(rv) << "_fdopen";
+ // _fdopen
+ CHECK(rv);
return rv;
}

Powered by Google App Engine
This is Rietveld 408576698