Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/public/cpp/bindings/lib/connector.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « mojo/edk/test/test_utils_win.cc ('k') | mojo/public/cpp/bindings/tests/binding_callback_unittest.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/connector.cc
diff --git a/mojo/public/cpp/bindings/lib/connector.cc b/mojo/public/cpp/bindings/lib/connector.cc
index 64524111eb2d36aabac90f28cb6e3c27cab5d2e8..d9da5faeb530027c2b98a826486db64769d732dc 100644
--- a/mojo/public/cpp/bindings/lib/connector.cc
+++ b/mojo/public/cpp/bindings/lib/connector.cc
@@ -148,7 +148,8 @@ bool Connector::Accept(Message* message) {
// TODO(vtl): I wonder if this should be a |DCHECK()|. (But, until
// crbug.com/389666, etc. are resolved, this will make tests fail quickly
// rather than hanging.)
- CHECK(false) << "Race condition or other bug detected";
+ // Race condition or other bug detected
+ CHECK(false);
return false;
default:
// This particular write was rejected, presumably because of bad input.
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « mojo/edk/test/test_utils_win.cc ('k') | mojo/public/cpp/bindings/tests/binding_callback_unittest.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698