Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: mojo/edk/test/test_utils_posix.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/test/test_utils_posix.cc
diff --git a/mojo/edk/test/test_utils_posix.cc b/mojo/edk/test/test_utils_posix.cc
index 60d5db59db0063057c155c9da5e0de46ac0fc4f8..3f33cc5e0d701719d221ab8f1f7eeeea74d34e06 100644
--- a/mojo/edk/test/test_utils_posix.cc
+++ b/mojo/edk/test/test_utils_posix.cc
@@ -77,7 +77,8 @@ bool NonBlockingRead(const PlatformHandle& handle,
ScopedPlatformHandle PlatformHandleFromFILE(base::ScopedFILE fp) {
CHECK(fp);
int rv = dup(fileno(fp.get()));
- PCHECK(rv != -1) << "dup";
+ // dup
+ CHECK(rv != -1);
return ScopedPlatformHandle(PlatformHandle(rv));
}
@@ -85,7 +86,8 @@ base::ScopedFILE FILEFromPlatformHandle(ScopedPlatformHandle h,
const char* mode) {
CHECK(h.is_valid());
base::ScopedFILE rv(fdopen(h.release().handle, mode));
- PCHECK(rv) << "fdopen";
+ // fdopen
+ CHECK(rv);
return rv;
}

Powered by Google App Engine
This is Rietveld 408576698