Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/edk/test/multiprocess_test_helper_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « mojo/edk/test/mojo_test_base.cc ('k') | mojo/edk/test/test_utils_posix.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/test/multiprocess_test_helper_unittest.cc
diff --git a/mojo/edk/test/multiprocess_test_helper_unittest.cc b/mojo/edk/test/multiprocess_test_helper_unittest.cc
index f7e9e832f401a6e9da0ad06350fef841d8760684..2b20adccfc73654b7d8e5e7d8904ee90faa5210c 100644
--- a/mojo/edk/test/multiprocess_test_helper_unittest.cc
+++ b/mojo/edk/test/multiprocess_test_helper_unittest.cc
@@ -141,7 +141,8 @@ MOJO_MULTIPROCESS_TEST_CHILD_TEST(ChildTestFailsAssert) {
ASSERT_FALSE(
IsNonBlocking(MultiprocessTestHelper::client_platform_handle.get()))
<< "Not reached";
- CHECK(false) << "Not reached";
+ // Not reached
+ CHECK(false);
}
TEST_F(MultiprocessTestHelperTest, ChildTestFailsExpect) {
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « mojo/edk/test/mojo_test_base.cc ('k') | mojo/edk/test/test_utils_posix.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698