Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: gin/isolate_holder.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/isolate_holder.cc
diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc
index 04449d26ab5657712c8c35d64da65b20424852ea..fd2af06a1ff77c9e63209735358bb11dab84afa5 100644
--- a/gin/isolate_holder.cc
+++ b/gin/isolate_holder.cc
@@ -33,7 +33,8 @@ IsolateHolder::IsolateHolder() : IsolateHolder(AccessMode::kSingleThread) {
IsolateHolder::IsolateHolder(AccessMode access_mode)
: access_mode_(access_mode) {
v8::ArrayBuffer::Allocator* allocator = g_array_buffer_allocator;
- CHECK(allocator) << "You need to invoke gin::IsolateHolder::Initialize first";
+ // You need to invoke gin::IsolateHolder::Initialize first
+ CHECK(allocator);
v8::Isolate::CreateParams params;
params.entry_hook = DebugImpl::GetFunctionEntryHook();
params.code_event_handler = DebugImpl::GetJitCodeEventHandler();

Powered by Google App Engine
This is Rietveld 408576698