Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/shell_runner.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « gin/isolate_holder.cc ('k') | gpu/perftests/texture_upload_perftest.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/shell_runner.cc
diff --git a/gin/shell_runner.cc b/gin/shell_runner.cc
index 0e534e4af027ca1cacb0e950ee0d6167dae5253e..1cda191531d35c26f52788b355eae028c16b5867 100644
--- a/gin/shell_runner.cc
+++ b/gin/shell_runner.cc
@@ -42,7 +42,7 @@ void ShellRunnerDelegate::DidRunScript(ShellRunner* runner) {
void ShellRunnerDelegate::UnhandledException(ShellRunner* runner,
TryCatch& try_catch) {
- CHECK(false) << try_catch.GetStackTrace();
+ LOG(FATAL) << try_catch.GetStackTrace();
}
ShellRunner::ShellRunner(ShellRunnerDelegate* delegate, Isolate* isolate)
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « gin/isolate_holder.cc ('k') | gpu/perftests/texture_upload_perftest.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698