Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gin/array_buffer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/array_buffer.cc
diff --git a/gin/array_buffer.cc b/gin/array_buffer.cc
index d40e8981bd4598a67ce9f8a4e81da041d0f1d8f1..3f257b69038efe0fa97360fbb392b8e92cd83f0f 100644
--- a/gin/array_buffer.cc
+++ b/gin/array_buffer.cc
@@ -87,9 +87,9 @@ class ArrayBuffer::Private : public base::RefCounted<ArrayBuffer::Private> {
scoped_refptr<ArrayBuffer::Private> ArrayBuffer::Private::From(
v8::Isolate* isolate, v8::Local<v8::ArrayBuffer> array) {
if (array->IsExternal()) {
+ // Cannot mix blink and gin ArrayBuffers.
CHECK_EQ(WrapperInfo::From(v8::Local<v8::Object>::Cast(array)),
- &g_array_buffer_wrapper_info)
- << "Cannot mix blink and gin ArrayBuffers";
+ &g_array_buffer_wrapper_info);
return make_scoped_refptr(static_cast<Private*>(
array->GetAlignedPointerFromInternalField(kEncodedValueIndex)));
}

Powered by Google App Engine
This is Rietveld 408576698