Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: extensions/common/manifest_test.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_test.cc
diff --git a/extensions/common/manifest_test.cc b/extensions/common/manifest_test.cc
index 6a966e60f0170353921aa8c48c7a68b0762a17fd..7aae33ec1496ea5178b102759f9e6ae0b560fd09 100644
--- a/extensions/common/manifest_test.cc
+++ b/extensions/common/manifest_test.cc
@@ -65,13 +65,15 @@ ManifestTest::ManifestData::ManifestData(const char* name)
ManifestTest::ManifestData::ManifestData(base::DictionaryValue* manifest,
const char* name)
: name_(name), manifest_(manifest) {
- CHECK(manifest_) << "Manifest NULL";
+ // Manifest NULL
+ CHECK(manifest_);
}
ManifestTest::ManifestData::ManifestData(
std::unique_ptr<base::DictionaryValue> manifest)
: manifest_(manifest.get()), manifest_holder_(std::move(manifest)) {
- CHECK(manifest_) << "Manifest NULL";
+ // Manifest NULL
+ CHECK(manifest_);
}
ManifestTest::ManifestData::ManifestData(
@@ -80,7 +82,8 @@ ManifestTest::ManifestData::ManifestData(
: name_(name),
manifest_(manifest.get()),
manifest_holder_(std::move(manifest)) {
- CHECK(manifest_) << "Manifest NULL";
+ // Manifest NULL
+ CHECK(manifest_);
}
ManifestTest::ManifestData::ManifestData(const ManifestData& m) {

Powered by Google App Engine
This is Rietveld 408576698