extensions/common/one_shot_event.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/one_shot_event.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/one_shot_event.cc

diff --git a/extensions/common/one_shot_event.cc b/extensions/common/one_shot_event.cc

index ee8b80a7274b3c95c625714ee5f1241651ceb550..c8ef3a153711b90b1e8ad33024d67393f0bdf5f1 100644

--- a/extensions/common/one_shot_event.cc

+++ b/extensions/common/one_shot_event.cc

@@ -65,7 +65,8 @@ void OneShotEvent::PostDelayed(const tracked_objects::Location& from_here,

void OneShotEvent::Signal() {

DCHECK(thread_checker_.CalledOnValidThread());

- CHECK(!signaled_) << "Only call Signal once.";

+ // Only call Signal once.

+ CHECK(!signaled_);

signaled_ = true;

// After this point, a call to Post() from one of the queued tasks