Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: extensions/common/manifest_handler.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handler.cc
diff --git a/extensions/common/manifest_handler.cc b/extensions/common/manifest_handler.cc
index 537bb9a1f8b7e71c62c1216899c850cdd65c3d64..c32b602ea696d7f408327438bde99fcffb8ae9fe 100644
--- a/extensions/common/manifest_handler.cc
+++ b/extensions/common/manifest_handler.cc
@@ -223,9 +223,9 @@ void ManifestHandlerRegistry::SortManifestHandlers() {
ManifestHandlerMap::const_iterator prereq_iter =
handlers_.find(prerequisites[i]);
// If the prerequisite does not exist, crash.
- CHECK(prereq_iter != handlers_.end())
- << "Extension manifest handler depends on unrecognized key "
- << prerequisites[i];
+ // Extension manifest handler depends on unrecognized key
+ // |prerequisites[i]|.
+ CHECK(prereq_iter != handlers_.end());
// Prerequisite is in our map.
if (base::ContainsKey(priority_map_, prereq_iter->second.get()))
unsatisfied--;
@@ -245,8 +245,8 @@ void ManifestHandlerRegistry::SortManifestHandlers() {
// If there are any leftover unsorted handlers, they must have had
// circular dependencies.
- CHECK_EQ(unsorted_handlers.size(), std::set<ManifestHandler*>::size_type(0))
- << "Extension manifest handlers have circular dependencies!";
+ // Extension manifest handlers have circular dependencies!
+ CHECK_EQ(unsorted_handlers.size(), std::set<ManifestHandler*>::size_type(0));
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698