Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/features/json_feature_provider_source.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « extensions/common/extension_api.cc ('k') | extensions/common/manifest_handler.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/json_feature_provider_source.cc
diff --git a/extensions/common/features/json_feature_provider_source.cc b/extensions/common/features/json_feature_provider_source.cc
index caf091431d06e81ddc3b02137d7a18c13afb5bf0..938f1f09312dca89f69528bbaaedddb4122a2ab2 100644
--- a/extensions/common/features/json_feature_provider_source.cc
+++ b/extensions/common/features/json_feature_provider_source.cc
@@ -31,7 +31,7 @@ void JSONFeatureProviderSource::LoadJSON(int resource_id) {
std::unique_ptr<base::DictionaryValue> value_as_dict;
if (value) {
- CHECK(value->IsType(base::Value::Type::DICTIONARY)) << name_;
+ CHECK(value->IsType(base::Value::Type::DICTIONARY));
value_as_dict = base::DictionaryValue::From(std::move(value));
} else {
// There was some error loading the features file.
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « extensions/common/extension_api.cc ('k') | extensions/common/manifest_handler.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698