content/browser/renderer_host/render_process_host_impl.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 1b15a1f12d054b7b3ef05ead9c855dbbabdb8d11..17fa6c7a1b5bbb93fc74bd57875041e061f577ce 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -1437,8 +1437,8 @@ mojom::RouteProvider* RenderProcessHostImpl::GetRemoteRouteProvider() {

void RenderProcessHostImpl::AddRoute(int32_t routing_id,

IPC::Listener* listener) {

- CHECK(!listeners_.Lookup(routing_id)) << "Found Routing ID Conflict: "

- << routing_id;

+ // Found Routing ID Conflict.

+ CHECK(!listeners_.Lookup(routing_id));

listeners_.AddWithID(listener, routing_id);

}