Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host_unittest.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc
index 04b7209b10fd07ec065651ff22dc1b44a9331a7c..0b260c4fa3da2a1d0b53c7f29bb9dfd6ac91f7db 100644
--- a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc
@@ -275,10 +275,9 @@ class AudioRendererHostTest : public testing::Test {
base::Bind(
[](std::string* out, const MediaDeviceEnumeration& result) {
// Index 0 is default, so use 1. Always exists because we use
- // fake devices.
+ // fake devices. We expect to have a nondefault device.
CHECK(result[MediaDeviceType::MEDIA_DEVICE_TYPE_AUDIO_OUTPUT]
- .size() > 1)
- << "Expected to have a nondefault device.";
+ .size() > 1);
*out = result[MediaDeviceType::MEDIA_DEVICE_TYPE_AUDIO_OUTPUT][1]
.device_id;
},
@@ -299,11 +298,10 @@ class AudioRendererHostTest : public testing::Test {
devices_to_enumerate,
base::Bind(
// Index 0 is default, so use 1. Always exists because we use
- // fake devices.
+ // fake devices. We expect to have a nondefault device.
[](std::string* out, const MediaDeviceEnumeration& result) {
CHECK(result[MediaDeviceType::MEDIA_DEVICE_TYPE_AUDIO_INPUT]
- .size() > 1)
- << "Expected to have a nondefault device.";
+ .size() > 1);
*out = result[MediaDeviceType::MEDIA_DEVICE_TYPE_AUDIO_INPUT][1]
.device_id;
},

Powered by Google App Engine
This is Rietveld 408576698