Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Represents the browser side of the browser <--> renderer communication 5 // Represents the browser side of the browser <--> renderer communication
6 // channel. There will be one RenderProcessHost per renderer process. 6 // channel. There will be one RenderProcessHost per renderer process.
7 7
8 #include "content/browser/renderer_host/render_process_host_impl.h" 8 #include "content/browser/renderer_host/render_process_host_impl.h"
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1419 matching lines...) Expand 10 before | Expand all | Expand 10 after
1430 mojom::Renderer* RenderProcessHostImpl::GetRendererInterface() { 1430 mojom::Renderer* RenderProcessHostImpl::GetRendererInterface() {
1431 return renderer_interface_.get(); 1431 return renderer_interface_.get();
1432 } 1432 }
1433 1433
1434 mojom::RouteProvider* RenderProcessHostImpl::GetRemoteRouteProvider() { 1434 mojom::RouteProvider* RenderProcessHostImpl::GetRemoteRouteProvider() {
1435 return remote_route_provider_.get(); 1435 return remote_route_provider_.get();
1436 } 1436 }
1437 1437
1438 void RenderProcessHostImpl::AddRoute(int32_t routing_id, 1438 void RenderProcessHostImpl::AddRoute(int32_t routing_id,
1439 IPC::Listener* listener) { 1439 IPC::Listener* listener) {
1440 CHECK(!listeners_.Lookup(routing_id)) << "Found Routing ID Conflict: " 1440 // Found Routing ID Conflict.
1441 << routing_id; 1441 CHECK(!listeners_.Lookup(routing_id));
1442 listeners_.AddWithID(listener, routing_id); 1442 listeners_.AddWithID(listener, routing_id);
1443 } 1443 }
1444 1444
1445 void RenderProcessHostImpl::RemoveRoute(int32_t routing_id) { 1445 void RenderProcessHostImpl::RemoveRoute(int32_t routing_id) {
1446 DCHECK(listeners_.Lookup(routing_id) != nullptr); 1446 DCHECK(listeners_.Lookup(routing_id) != nullptr);
1447 listeners_.Remove(routing_id); 1447 listeners_.Remove(routing_id);
1448 Cleanup(); 1448 Cleanup();
1449 } 1449 }
1450 1450
1451 void RenderProcessHostImpl::AddObserver(RenderProcessHostObserver* observer) { 1451 void RenderProcessHostImpl::AddObserver(RenderProcessHostObserver* observer) {
(...skipping 1549 matching lines...) Expand 10 before | Expand all | Expand 10 after
3001 LOG(ERROR) << "Terminating render process for bad Mojo message: " << error; 3001 LOG(ERROR) << "Terminating render process for bad Mojo message: " << error;
3002 3002
3003 // The ReceivedBadMessage call below will trigger a DumpWithoutCrashing. 3003 // The ReceivedBadMessage call below will trigger a DumpWithoutCrashing.
3004 // Capture the error message in a crash key value. 3004 // Capture the error message in a crash key value.
3005 base::debug::ScopedCrashKey error_key_value("mojo-message-error", error); 3005 base::debug::ScopedCrashKey error_key_value("mojo-message-error", error);
3006 bad_message::ReceivedBadMessage(render_process_id, 3006 bad_message::ReceivedBadMessage(render_process_id,
3007 bad_message::RPH_MOJO_PROCESS_ERROR); 3007 bad_message::RPH_MOJO_PROCESS_ERROR);
3008 } 3008 }
3009 3009
3010 } // namespace content 3010 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698