Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: components/sync/engine_impl/sync_scheduler_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/sync_scheduler_impl.cc
diff --git a/components/sync/engine_impl/sync_scheduler_impl.cc b/components/sync/engine_impl/sync_scheduler_impl.cc
index fe52722f06229f13fd092c27807bf8715bc9d0be..8f4b814b617951db8c6c4e72645a5416682aa0f4 100644
--- a/components/sync/engine_impl/sync_scheduler_impl.cc
+++ b/components/sync/engine_impl/sync_scheduler_impl.cc
@@ -293,7 +293,8 @@ void SyncSchedulerImpl::ScheduleConfiguration(
DCHECK(IsConfigRelatedUpdateSourceValue(params.source));
DCHECK_EQ(CONFIGURATION_MODE, mode_);
DCHECK(!params.ready_task.is_null());
- CHECK(started_) << "Scheduler must be running to configure.";
+ // Scheduler must be running to configure.
+ CHECK(started_);
SDVLOG(2) << "Reconfiguring syncer.";
// Only one configuration is allowed at a time. Verify we're not waiting
@@ -320,7 +321,8 @@ void SyncSchedulerImpl::ScheduleClearServerData(const ClearParams& params) {
DCHECK_EQ(CLEAR_SERVER_DATA_MODE, mode_);
DCHECK(!pending_configure_params_);
DCHECK(!params.report_success_task.is_null());
- CHECK(started_) << "Scheduler must be running to clear.";
+ // Scheduler must be running to clear.
+ CHECK(started_);
pending_clear_params_ = base::MakeUnique<ClearParams>(params);
TrySyncCycleJob();
}

Powered by Google App Engine
This is Rietveld 408576698