components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc ('k') | components/sync/engine_impl/sync_scheduler_impl.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc

diff --git a/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc b/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc

index 402d817dc4bb8a2a0429c9880a2204d64825ff92..41f14dcd49ad38c650ad064dee0e809b1faae120 100644

--- a/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc

+++ b/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc

@@ -40,9 +40,8 @@ PersistentUniqueClientEntity::~PersistentUniqueClientEntity() {}

// static

std::unique_ptr<LoopbackServerEntity> PersistentUniqueClientEntity::Create(

const sync_pb::SyncEntity& client_entity) {

- CHECK(client_entity.has_client_defined_unique_tag())

- << "A PersistentUniqueClientEntity must have a client-defined unique "

- "tag.";

+ // A PersistentUniqueClientEntity must have a client-defined unique tag.

+ CHECK(client_entity.has_client_defined_unique_tag());

ModelType model_type = GetModelTypeFromSpecifics(client_entity.specifics());

string id = EffectiveIdForClientTaggedEntity(client_entity);

return std::unique_ptr<LoopbackServerEntity>(new PersistentUniqueClientEntity(