Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: components/sync/engine_impl/syncer_util.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/syncer_util.cc
diff --git a/components/sync/engine_impl/syncer_util.cc b/components/sync/engine_impl/syncer_util.cc
index 3d80bac15393224b99b70f1931d2d9b8411d9751..19a1897873721e322022ff665a1f2ca947cdb6ab 100644
--- a/components/sync/engine_impl/syncer_util.cc
+++ b/components/sync/engine_impl/syncer_util.cc
@@ -472,7 +472,8 @@ void UpdateLocalDataFromServerData(syncable::WriteTransaction* trans,
VerifyCommitResult ValidateCommitEntry(syncable::Entry* entry) {
syncable::Id id = entry->GetId();
if (id == entry->GetParentId()) {
- CHECK(id.IsRoot()) << "Non-root item is self parenting." << *entry;
+ // Non-root item is self parenting.
+ CHECK(id.IsRoot());
// If the root becomes unsynced it can cause us problems.
LOG(ERROR) << "Root item became unsynced " << *entry;
return VERIFY_UNSYNCABLE;

Powered by Google App Engine
This is Rietveld 408576698