Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/pdf/renderer/pdf_accessibility_tree.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/pairing/fake_host_pairing_controller.cc ('k') | components/pdf/renderer/pepper_pdf_host.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/pdf/renderer/pdf_accessibility_tree.cc
diff --git a/components/pdf/renderer/pdf_accessibility_tree.cc b/components/pdf/renderer/pdf_accessibility_tree.cc
index 2817090525797e4a5101ed7003ae0f222d580c6f..644d6b0ff0b0eb10f7f027cbdbe8682e701696ec 100644
--- a/components/pdf/renderer/pdf_accessibility_tree.cc
+++ b/components/pdf/renderer/pdf_accessibility_tree.cc
@@ -192,7 +192,8 @@ void PdfAccessibilityTree::Finish() {
for (const auto& node : nodes_)
update.nodes.push_back(*node);
- CHECK(tree_.Unserialize(update)) << update.ToString() << tree_.error();
+ if (!tree_.Unserialize(update))
+ LOG(FATAL) << tree_.error() << ": " << update.ToString();
content::RenderAccessibility* render_accessibility = GetRenderAccessibility();
if (render_accessibility)
render_accessibility->SetPluginTreeSource(this);
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/pairing/fake_host_pairing_controller.cc ('k') | components/pdf/renderer/pepper_pdf_host.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698