Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: components/pairing/fake_host_pairing_controller.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/pairing/fake_host_pairing_controller.cc
diff --git a/components/pairing/fake_host_pairing_controller.cc b/components/pairing/fake_host_pairing_controller.cc
index f0300f2dd5468cf47a91c98c11f1d1ddf2cd2941..87b20c7066b302a1797693cf8e89c29cd3d36c6b 100644
--- a/components/pairing/fake_host_pairing_controller.cc
+++ b/components/pairing/fake_host_pairing_controller.cc
@@ -41,14 +41,14 @@ FakeHostPairingController::~FakeHostPairingController() {
void FakeHostPairingController::ApplyConfig(const std::string& config) {
base::StringPairs kv_pairs;
- CHECK(base::SplitStringIntoKeyValuePairs(config, ':', ',', &kv_pairs))
- << "Wrong config format.";
+ // Wrong config format.
+ CHECK(base::SplitStringIntoKeyValuePairs(config, ':', ',', &kv_pairs));
std::map<std::string, std::string> dict(kv_pairs.begin(), kv_pairs.end());
if (dict.count("async_duration")) {
int ms = 0;
- CHECK(base::StringToInt(dict["async_duration"], &ms))
- << "Wrong 'async_duration' format.";
+ // Wrong 'async_duration' format.
+ CHECK(base::StringToInt(dict["async_duration"], &ms));
async_duration_ = base::TimeDelta::FromMilliseconds(ms);
} else {
async_duration_ =
@@ -66,9 +66,10 @@ void FakeHostPairingController::ApplyConfig(const std::string& config) {
for (size_t i = 0; i < kCodeLength; ++i)
confirmation_code_.push_back(base::RandInt('0', '9'));
}
+ // Wrong 'code' format.
CHECK(confirmation_code_.length() == kCodeLength &&
- confirmation_code_.find_first_not_of("0123456789") == std::string::npos)
- << "Wrong 'code' format.";
+ confirmation_code_.find_first_not_of("0123456789") ==
+ std::string::npos);
device_name_ =
dict.count("device_name") ? dict["device_name"] : "Chromebox-01";

Powered by Google App Engine
This is Rietveld 408576698