components/pdf/renderer/pepper_pdf_host.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pdf/renderer/pepper_pdf_host.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/pdf/renderer/pepper_pdf_host.cc

diff --git a/components/pdf/renderer/pepper_pdf_host.cc b/components/pdf/renderer/pepper_pdf_host.cc

index c56d78e97ca11dac681911a558d2a9168da609ae..cdf5bde6944fe3d1ef3fab75335945297a582a68 100644

--- a/components/pdf/renderer/pepper_pdf_host.cc

+++ b/components/pdf/renderer/pepper_pdf_host.cc

@@ -56,8 +56,8 @@ bool PepperPDFHost::InvokePrintingForInstance(PP_Instance instance_id) {

// static

void PepperPDFHost::SetPrintClient(PepperPDFHost::PrintClient* client) {

- CHECK(!g_print_client_tls.Pointer()->Get())

- << "There should only be a single PrintClient for one RenderThread.";

+ // There should only be a single PrintClient for one RenderThread.

+ CHECK(!g_print_client_tls.Pointer()->Get());

g_print_client_tls.Pointer()->Set(client);

}