Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/guest_view/browser/guest_view_manager.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/grpc_support/test/quic_test_server.cc ('k') | components/json_schema/json_schema_validator.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/guest_view/browser/guest_view_manager.cc
diff --git a/components/guest_view/browser/guest_view_manager.cc b/components/guest_view/browser/guest_view_manager.cc
index 315ea635bfd49e4d1ff029709ff9c39e657d48b8..0643a4f941f9129cc934a09da02b3fed3d289bd3 100644
--- a/components/guest_view/browser/guest_view_manager.cc
+++ b/components/guest_view/browser/guest_view_manager.cc
@@ -294,8 +294,8 @@ void GuestViewManager::ViewCreated(int embedder_process_id,
if (guest_view_registry_.empty())
RegisterGuestViewTypes();
auto view_it = guest_view_registry_.find(view_type);
- CHECK(view_it != guest_view_registry_.end())
- << "Invalid GuestView created of type \"" << view_type << "\"";
+ // Invalid GuestView created from |view_type|.
+ CHECK(view_it != guest_view_registry_.end());
// Register the cleanup callback for when this view is destroyed.
RegisterViewDestructionCallback(embedder_process_id,
« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/grpc_support/test/quic_test_server.cc ('k') | components/json_schema/json_schema_validator.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698