components/grpc_support/test/quic_test_server.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/grpc_support/test/quic_test_server.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/grpc_support/test/quic_test_server.cc

diff --git a/components/grpc_support/test/quic_test_server.cc b/components/grpc_support/test/quic_test_server.cc

index d57f94ce706abf6220ba0ea996ed7e52ebf9b0f7..570f5dd8b4e1ce7236350470f0fcd8d343b74df1 100644

--- a/components/grpc_support/test/quic_test_server.cc

+++ b/components/grpc_support/test/quic_test_server.cc

@@ -83,7 +83,8 @@ void StartQuicServerOnServerThread(const base::FilePath& test_files_root,

// Start listening on an unbound port.

int rv = g_quic_server->Listen(

net::IPEndPoint(net::IPAddress::IPv4AllZeros(), 0));

- CHECK_GE(rv, 0) << "Quic server fails to start";

+ // Quic server fails to start

+ CHECK_GE(rv, 0);

g_quic_server_port = g_quic_server->server_address().port();

server_started_event->Signal();