Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: components/guest_view/browser/guest_view_manager.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/guest_view/browser/guest_view_manager.h" 5 #include "components/guest_view/browser/guest_view_manager.h"
6 6
7 #include <tuple> 7 #include <tuple>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 embedders_observed_.erase(embedder_process_id); 287 embedders_observed_.erase(embedder_process_id);
288 CallViewDestructionCallbacks(embedder_process_id); 288 CallViewDestructionCallbacks(embedder_process_id);
289 } 289 }
290 290
291 void GuestViewManager::ViewCreated(int embedder_process_id, 291 void GuestViewManager::ViewCreated(int embedder_process_id,
292 int view_instance_id, 292 int view_instance_id,
293 const std::string& view_type) { 293 const std::string& view_type) {
294 if (guest_view_registry_.empty()) 294 if (guest_view_registry_.empty())
295 RegisterGuestViewTypes(); 295 RegisterGuestViewTypes();
296 auto view_it = guest_view_registry_.find(view_type); 296 auto view_it = guest_view_registry_.find(view_type);
297 CHECK(view_it != guest_view_registry_.end()) 297 // Invalid GuestView created from |view_type|.
298 << "Invalid GuestView created of type \"" << view_type << "\""; 298 CHECK(view_it != guest_view_registry_.end());
299 299
300 // Register the cleanup callback for when this view is destroyed. 300 // Register the cleanup callback for when this view is destroyed.
301 RegisterViewDestructionCallback(embedder_process_id, 301 RegisterViewDestructionCallback(embedder_process_id,
302 view_instance_id, 302 view_instance_id,
303 base::Bind(view_it->second.cleanup_function, 303 base::Bind(view_it->second.cleanup_function,
304 context_, 304 context_,
305 embedder_process_id, 305 embedder_process_id,
306 view_instance_id)); 306 view_instance_id));
307 } 307 }
308 308
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 const GuestViewCreateFunction& create_function, 503 const GuestViewCreateFunction& create_function,
504 const GuestViewCleanUpFunction& cleanup_function) 504 const GuestViewCleanUpFunction& cleanup_function)
505 : create_function(create_function), cleanup_function(cleanup_function) {} 505 : create_function(create_function), cleanup_function(cleanup_function) {}
506 506
507 GuestViewManager::GuestViewData::GuestViewData(const GuestViewData& other) = 507 GuestViewManager::GuestViewData::GuestViewData(const GuestViewData& other) =
508 default; 508 default;
509 509
510 GuestViewManager::GuestViewData::~GuestViewData() {} 510 GuestViewManager::GuestViewData::~GuestViewData() {}
511 511
512 } // namespace guest_view 512 } // namespace guest_view
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698