components/dom_distiller/standalone/content_extractor_browsertest.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/standalone/content_extractor_browsertest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/form_structure_browsertest.cc ('K') | « components/display_compositor/yuv_readback_unittest.cc ('k') | components/grpc_support/test/quic_test_server.cc » ('j') | remoting/host/curtain_mode_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/standalone/content_extractor_browsertest.cc

diff --git a/components/dom_distiller/standalone/content_extractor_browsertest.cc b/components/dom_distiller/standalone/content_extractor_browsertest.cc

index cbae88bcab0bd2cec43e3aa9382feb3677e93954..4f87d72b169aaaf1d7bd5989bdfb0f7c9e0ac602 100644

--- a/components/dom_distiller/standalone/content_extractor_browsertest.cc

+++ b/components/dom_distiller/standalone/content_extractor_browsertest.cc

@@ -307,7 +307,8 @@ class ContentExtractionRequest : public ViewRequestDelegate {

void OnArticleReady(const DistilledArticleProto* article_proto) override {

article_proto_ = article_proto;

- CHECK(article_proto->pages_size()) << "Failed extracting " << url_;

+ // Failed extracting |url_|.

+ CHECK(article_proto->pages_size());

base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,

finished_callback_);

}